Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set capabilities on regal new rule #449

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

anderseknert
Copy link
Member

Tbh, we should probably reconsider if we should add capabilities as part of unmarshalling? But for now let's just fix the bug.

Fixes #446

Tbh, we should probably reconsider if we should add
capabilities as part of unmarshalling? But for now
let's just fix the bug.

Fixes #446

Signed-off-by: Anders Eknert <[email protected]>
Copy link
Member

@johanfylling johanfylling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anderseknert anderseknert merged commit f6b1eef into main Nov 8, 2023
2 checks passed
@anderseknert anderseknert deleted the no-capabilities-for-new branch November 8, 2023 14:56
srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
Tbh, we should probably reconsider if we should add
capabilities as part of unmarshalling? But for now
let's just fix the bug.

Fixes StyraInc#446

Signed-off-by: Anders Eknert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The regal new rule command writes capabilities object to the provided config
2 participants