Rule: use-if and use-contains
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
if-empty-object
branch
from
ee4d6cd to
690e375
Compare
anderseknert
force-pushed
the
use-if-and-contains
branch
from
9251f80 to
bfa1f4b
Compare
charlieegan3
approved these changes
Nov 15, 2023
anderseknert
force-pushed
the
use-if-and-contains
branch
from
bfa1f4b to
f317424
Compare
|
@charlieegan3 |
Recommend the use of `if` and `contains` when available as capabilities. Some fixes to tests where we didn't live up to this standard ourselves. Great! Fixes #468 Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
use-if-and-contains
branch
from
f317424 to
ea355eb
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Recommend the use of `if` and `contains` when available as capabilities. Some fixes to tests where we didn't live up to this standard ourselves. Great! Fixes StyraInc#468 Signed-off-by: Anders Eknert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommend the use of
ifandcontainswhen available as capabilities.Some fixes to tests where we didn't live up to this standard ourselves. Great!
(Note that this is targeting the
if-empty-objectbranch as that contained a few improvements that I wanted here, so that should be merged before this PR)Fixes #468