lsp: Implement code actions for new fixes #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
force-pushed
the
lsp-fixes-for-comment-assignment
branch
from
b84da98 to
8adb96d
Compare
charlieegan3
commented
Apr 18, 2024
anderseknert
approved these changes
Apr 18, 2024
| "extract target and location": { | ||
| ExecuteCommandParams: types.ExecuteCommandParams{ | ||
| Command: "example", | ||
| Arguments: []interface{}{"target", "1", 2}, // different types for testing, but should be strings |
There was a problem hiding this comment.
I suppose we could have standardized on args just being a single object for all commands, which we could serialize into a struct. But this might be more aligned with what the LSP "expects".
There was a problem hiding this comment.
Yeah I wasn't so sure about this but figured that we'd go with this until we ran into some issues. It's all internal so seemed ok to go with this for now.
#653 added fixes for no-whitespace-comment and use-assignment-operator. This PR adds code actions for these in the regal lsp. Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
force-pushed
the
lsp-fixes-for-comment-assignment
branch
from
8adb96d to
3684090
Compare
Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
force-pushed
the
lsp-fixes-for-comment-assignment
branch
from
c9dd044 to
3a1d447
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* lsp: Implement code actions for new fixes StyraInc#653 added fixes for no-whitespace-comment and use-assignment-operator. This PR adds code actions for these in the regal lsp. Signed-off-by: Charlie Egan <[email protected]> * Move commands under a fix namespace Signed-off-by: Charlie Egan <[email protected]> --------- Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#653 added fixes for no-whitespace-comment and use-assignment-operator. This PR adds code actions for these in the regal lsp.
Fixes #659
Fixes #649