Skip to content

Commit

Permalink
Merge "Remove unused logging symbols."
Browse files Browse the repository at this point in the history
  • Loading branch information
twasilczyk authored and Gerrit Code Review committed Aug 1, 2018
2 parents 52126a4 + 3b70eed commit 081b710
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
5 changes: 0 additions & 5 deletions base/include/android-base/logging.h
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,6 @@ class LogMessage {
private:
const std::unique_ptr<LogMessageData> data_;

// TODO(b/35361699): remove these symbols once all prebuilds stop using it.
LogMessage(const char* file, unsigned int line, LogId id, LogSeverity severity, int error);
static void LogLine(const char* file, unsigned int line, LogId id, LogSeverity severity,
const char* msg);

DISALLOW_COPY_AND_ASSIGN(LogMessage);
};

Expand Down
9 changes: 0 additions & 9 deletions base/logging.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -410,10 +410,6 @@ LogMessage::LogMessage(const char* file, unsigned int line, LogId id, LogSeverit
const char* tag, int error)
: data_(new LogMessageData(file, line, id, severity, tag, error)) {}

LogMessage::LogMessage(const char* file, unsigned int line, LogId id, LogSeverity severity,
int error)
: LogMessage(file, line, id, severity, nullptr, error) {}

LogMessage::~LogMessage() {
// Check severity again. This is duplicate work wrt/ LOG macros, but not LOG_STREAM.
if (!WOULD_LOG(data_->GetSeverity())) {
Expand Down Expand Up @@ -470,11 +466,6 @@ void LogMessage::LogLine(const char* file, unsigned int line, LogId id, LogSever
}
}

void LogMessage::LogLine(const char* file, unsigned int line, LogId id, LogSeverity severity,
const char* message) {
LogLine(file, line, id, severity, nullptr, message);
}

LogSeverity GetMinimumLogSeverity() {
return gMinimumLogSeverity;
}
Expand Down

0 comments on commit 081b710

Please sign in to comment.