Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc links #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update doc links #360

wants to merge 1 commit into from

Conversation

kamilxdomo
Copy link

No description provided.

@kamilxdomo kamilxdomo linked an issue Sep 13, 2024 that may be closed by this pull request
@olliemath
Copy link
Member

@kamilxdomo this doesn't work - you can see your updated markdown doc over here: https://github.com/SuadeLabs/fire/blob/ef72429cacbf39d6763fc6a162df5058d80ee504/documentation/properties/snp_lt.md - try clicking the link

A deeper question is: why does the test pass when the link doesn't work when we click on it? Possibly the test is doing extra clever stuff that our browser doesn't?

@kamilxdomo
Copy link
Author

kamilxdomo commented Sep 13, 2024

@kamilxdomo this doesn't work - you can see your updated markdown doc over here: https://github.com/SuadeLabs/fire/blob/ef72429cacbf39d6763fc6a162df5058d80ee504/documentation/properties/snp_lt.md - try clicking the link

A deeper question is: why does the test pass when the link doesn't work when we click on it? Possibly the test is doing extra clever stuff that our browser doesn't?

it does look poorly formatted when clicked, and I see the clink then doesn't work from the property page

I'm not 100% sure what, but I know that the test is also checking certificates. Maybe this could be the extra step?
image

@muratabur
Copy link
Contributor

@kamilxdomo did this get resolved, ready to merge?

@kamilxdomo
Copy link
Author

@olliemath would you be able to confirm if these are okay now? for me the link is working

@muratabur
Copy link
Contributor

still has conflicts....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docs links SSL
3 participants