Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DATA_DICTIONARY.md #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create DATA_DICTIONARY.md #3

wants to merge 1 commit into from

Conversation

DeluxeRaph
Copy link
Member

No description provided.

mikeghen
mikeghen requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@mikeghen mikeghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, I left some comments mainly around reorganizing the file.

DATA_DICTIONARY.md
@@ -0,0 +1,71 @@
# Data Dictionary for Super DCA Metrics

### Average Price Impact
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make tables for this information vs. repeating "query title""chart name" "chart description" so many times.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, as a table it'll be clearer which charts show multiple metrics shown on them.

DATA_DICTIONARY.md
@@ -0,0 +1,71 @@
# Data Dictionary for Super DCA Metrics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include an image of the dashboard

DATA_DICTIONARY.md

---

### Average Time Between UniwapsSuper DCA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a typo

DATA_DICTIONARY.md
@@ -0,0 +1,71 @@
# Data Dictionary for Super DCA Metrics

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a "Metrics" table which works like a glossary, two columns: Metric, Description.

Include a formula when the metric is more than a simple average or sum, e.g. for the "Oracle Delta" or whatever we want to call it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeghen mikeghen mikeghen requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeluxeRaph @mikeghen