wip: convert shared packages to esm (doesn't build, needs doing to ap…

…ps too)

.eslintrc.cjs

@@ -8,19 +8,19 @@ module.exports = {
 	ignorePatterns: ['**/dist/**/*', '**/__tests__/**/*'],
 	rules: {
 		'no-console': 'warn',
-		'node/no-unpublished-import': [
+		'n/no-unpublished-import': [
 			'error',
 			{
 				allowModules: ['electron', 'typed-emitter', 'electron-devtools-installer'],
 			},
 		],
-		'node/no-unpublished-require': [
+		'n/no-unpublished-require': [
 			'error',
 			{
 				allowModules: ['html-webpack-plugin', 'electron-notarize'],
 			},
 		],
-		'node/no-extraneous-import': [
+		'n/no-extraneous-import': [
 			'error',
 			{
 				allowModules: [
@@ -59,8 +59,8 @@ module.exports = {
 			rules: {
 				...commonRules,
 				...tsRules,
-				// "node/no-extraneous-import": "off", // because there are a lot of them as dev-dependencies
-				'node/no-missing-import': 'off', // erroring on every single import
+				// "n/no-extraneous-import": "off", // because there are a lot of them as dev-dependencies
+				'n/no-missing-import': 'off', // erroring on every single import
 				'react/prop-types': 'off', // we don't use this
 				// "@typescript-eslint/no-empty-interface": "off", // many prop/state types are {}
 				'@typescript-eslint/promise-function-async': 'off', // event handlers can't be async

apps/app/jest.config.js

@@ -1,4 +1,4 @@
-// eslint-disable-next-line node/no-unpublished-require
+// eslint-disable-next-line n/no-unpublished-require
 const base = require('../../jest.config.base')
 const packageJson = require('./package')
 

apps/app/src/react/App.tsx

@@ -62,7 +62,7 @@ const ENABLE_WHY_DID_YOU_RENDER = false
 if (process.env.NODE_ENV === 'development' && ENABLE_WHY_DID_YOU_RENDER) {
 	// eslint-disable-next-line no-console
 	console.log('Why-did-you-render-enabled')
-	// eslint-disable-next-line @typescript-eslint/no-require-imports, node/no-unpublished-require
+	// eslint-disable-next-line @typescript-eslint/no-require-imports, n/no-unpublished-require
 	const whyDidYouRender = require('@welldone-software/why-did-you-render')
 	whyDidYouRender(React, {
 		trackAllPureComponents: true,

apps/app/src/react/components/sidebar/timelineObj/GDD/lib.ts

@@ -1,6 +1,6 @@
 import { GDDSchema } from 'graphics-data-definition'
 import { TSRTimelineContent, TSRTimelineObj } from 'timeline-state-resolver-types'
-// eslint-disable-next-line node/no-missing-import
+// eslint-disable-next-line n/no-missing-import
 import { OnSave } from '../timelineObjs/lib'
 
 export function getBasicType(schemaType: string | string[]): string {

package.json

@@ -44,6 +44,7 @@
 	},
 	"devDependencies": {
 		"@sofie-automation/eslint-plugin": "^0.1.1",
+		"@tsconfig/node20": "^20.1.4",
 		"@types/jest": "^29.5.13",
 		"@types/node": "^20.16.11",
 		"@types/shelljs": "^0",
@@ -52,7 +53,7 @@
 		"eslint": "^8.57.1",
 		"eslint-config-prettier": "^8.10.0",
 		"eslint-plugin-jest": "^28.8.3",
-		"eslint-plugin-node": "^11.1.0",
+		"eslint-plugin-n": "^17.11.1",
 		"eslint-plugin-prettier": "^4.2.1",
 		"eslint-plugin-react": "^7.37.1",
 		"eslint-plugin-react-hooks": "^4.6.2",

scripts/license-check.js

@@ -1,4 +1,4 @@
-/* eslint-disable no-process-exit, node/no-unpublished-require, node/no-extraneous-require */
+/* eslint-disable no-process-exit, n/no-unpublished-require, n/no-extraneous-require */
 'use strict'
 const fs = require('fs')
 const path = require('path')

shared/packages/api/package.json

@@ -10,11 +10,12 @@
 	"homepage": "https://github.com/SuperFlyTV/SuperConductor#readme",
 	"license": "AGPL-3.0-or-later",
 	"private": true,
+	"type": "module",
 	"engines": {
 		"node": "20"
 	},
-	"main": "dist/index",
-	"types": "dist/index",
+	"main": "dist/index.js",
+	"types": "dist/index.d.ts",
 	"files": [
 		"dist"
 	],

shared/packages/api/src/bridgeAPI.ts

@@ -1,8 +1,8 @@
 import { MetadataAny, ResourceAny, TSRDeviceId, SerializedProtectedMap } from '@shared/models'
-import { AnalogValue, KnownPeripheral, PeripheralId, PeripheralSettingsAny } from './peripherals'
+import { AnalogValue, KnownPeripheral, PeripheralId, PeripheralSettingsAny } from './peripherals.js'
 import { DeviceOptionsAny, Mappings, TSRTimeline } from 'timeline-state-resolver-types'
-import { KeyDisplay, KeyDisplayTimeline, PeripheralInfo } from './peripherals'
-import { BridgeId } from './bridge'
+import { KeyDisplay, KeyDisplayTimeline, PeripheralInfo } from './peripherals.js'
+import { BridgeId } from './bridge.js'
 
 export namespace BridgeAPI {
 	export namespace FromBridge {

shared/packages/api/src/index.ts

@@ -1,4 +1,4 @@
-export * from './bridge'
-export * from './bridgeAPI'
-export * from './peripherals'
-export * from './logging'
+export * from './bridge.js'
+export * from './bridgeAPI.js'
+export * from './peripherals.js'
+export * from './logging.js'

shared/packages/api/tsconfig.json

@@ -2,12 +2,8 @@
 	"extends": "../../../tsconfig.json",
 	"compilerOptions": {
 		"rootDir": "src",
-		"outDir": "dist",
-		"lib": [
-			"es6"
-		]
+		"outDir": "dist"
 	},
-	"exclude": [
-		"src/**/__tests__/**/*"
-	]
+	"include": ["src/**/*.ts"],
+	"exclude": ["src/**/__tests__/**/*"]
 }

shared/packages/lib/package.json

@@ -10,11 +10,12 @@
 	"homepage": "https://github.com/SuperFlyTV/SuperConductor#readme",
 	"license": "AGPL-3.0-or-later",
 	"private": true,
+	"type": "module",
 	"engines": {
 		"node": "20"
 	},
-	"main": "dist/index",
-	"types": "dist/index",
+	"main": "dist/index.js",
+	"types": "dist/index.d.ts",
 	"files": [
 		"dist"
 	],

shared/packages/lib/src/Resources.ts

@@ -1,5 +1,5 @@
 import { protectString, ResourceAny, ResourceType, ResourceId } from '@shared/models'
-import { assertNever } from './lib'
+import { assertNever } from './lib.js'
 import {
 	TSRTimelineObj,
 	TSRTimelineContent,

shared/packages/lib/src/TimelineTracker.ts

@@ -7,7 +7,7 @@ import {
 	TimelineObjectInstance,
 } from 'superfly-timeline'
 import _ from 'lodash'
-import { deepClone } from './lib'
+import { deepClone } from './lib.js'
 
 export class TimelineTracker {
 	private timeline: TimelineObject[]

shared/packages/lib/src/index.ts

@@ -1,6 +1,6 @@
-export * from './bytesToSize'
-export * from './color'
-export * from './lib'
-export * from './peripheral'
-export * from './Resources'
-export * from './TimelineTracker'
+export * from './bytesToSize.js'
+export * from './color.js'
+export * from './lib.js'
+export * from './peripheral.js'
+export * from './Resources.js'
+export * from './TimelineTracker.js'

shared/packages/lib/tsconfig.json

@@ -2,9 +2,7 @@
 	"extends": "../../../tsconfig.json",
 	"compilerOptions": {
 		"rootDir": "src",
-		"outDir": "dist",
-		"lib": [
-			"es6"
-		]
+		"outDir": "dist"
 	},
+	"include": ["src/**/*.ts"]
 }

shared/packages/models/package.json

@@ -10,11 +10,12 @@
 	"homepage": "https://github.com/SuperFlyTV/SuperConductor#readme",
 	"license": "AGPL-3.0-or-later",
 	"private": true,
+	"type": "module",
 	"engines": {
 		"node": "20"
 	},
-	"main": "dist/index",
-	"types": "dist/index",
+	"main": "dist/index.js",
+	"types": "dist/index.d.ts",
 	"files": [
 		"dist"
 	],

shared/packages/models/src/index.ts

@@ -1,4 +1,4 @@
-export * from './resource'
-export * from './metadata'
-export * from './protectedString'
-export * from './tsrDevice'
+export * from './resource/index.js'
+export * from './metadata/index.js'
+export * from './protectedString.js'
+export * from './tsrDevice.js'

shared/packages/models/src/metadata/Atem.ts

@@ -1,5 +1,5 @@
-import { InputState } from 'atem-connection'
-import { MetadataBase, MetadataType } from './metadata'
+import type { InputState } from 'atem-connection'
+import { MetadataBase, MetadataType } from './metadata.js'
 
 export interface AtemMetadata extends MetadataBase {
 	metadataType: MetadataType.ATEM

shared/packages/models/src/metadata/CasparCG.ts

@@ -1,4 +1,4 @@
-import { MetadataBase, MetadataType } from './metadata'
+import { MetadataBase, MetadataType } from './metadata.js'
 
 export interface CasparCGMetadata extends MetadataBase {
 	metadataType: MetadataType.CASPARCG

shared/packages/models/src/metadata/HTTPSend.ts

@@ -1,4 +1,4 @@
-import { MetadataBase, MetadataType } from './metadata'
+import { MetadataBase, MetadataType } from './metadata.js'
 
 export interface HTTPSendMetadata extends MetadataBase {
 	metadataType: MetadataType.HTTP_SEND

shared/packages/models/src/metadata/Hyperdeck.ts

@@ -1,4 +1,4 @@
-import { MetadataBase, MetadataType } from './metadata'
+import { MetadataBase, MetadataType } from './metadata.js'
 
 export interface HyperdeckMetadata extends MetadataBase {
 	metadataType: MetadataType.HYPERDECK

shared/packages/models/src/metadata/OBS.ts

@@ -1,4 +1,4 @@
-import { MetadataBase, MetadataType } from './metadata'
+import { MetadataBase, MetadataType } from './metadata.js'
 
 export interface OBSMetadata extends MetadataBase {
 	metadataType: MetadataType.OBS

shared/packages/models/src/metadata/OSC.ts

@@ -1,4 +1,4 @@
-import { MetadataBase, MetadataType } from './metadata'
+import { MetadataBase, MetadataType } from './metadata.js'
 
 export interface OSCMetadata extends MetadataBase {
 	metadataType: MetadataType.OSC

shared/packages/models/src/metadata/TCPSend.ts

@@ -1,4 +1,4 @@
-import { MetadataBase, MetadataType } from './metadata'
+import { MetadataBase, MetadataType } from './metadata.js'
 
 export interface TCPSendMetadata extends MetadataBase {
 	metadataType: MetadataType.TCP_SEND

shared/packages/models/src/metadata/TriCaster.ts

@@ -1,4 +1,4 @@
-import { MetadataBase, MetadataType } from './metadata'
+import { MetadataBase, MetadataType } from './metadata.js'
 
 export interface TriCasterMetadata extends MetadataBase {
 	metadataType: MetadataType.TRICASTER

shared/packages/models/src/metadata/VMix.ts

@@ -1,4 +1,4 @@
-import { MetadataBase, MetadataType } from './metadata'
+import { MetadataBase, MetadataType } from './metadata.js'
 
 export interface VMixMetadata extends MetadataBase {
 	metadataType: MetadataType.VMIX

shared/packages/models/src/metadata/index.ts

@@ -1,10 +1,10 @@
-export * from './metadata'
-export * from './Atem'
-export * from './CasparCG'
-export * from './HTTPSend'
-export * from './OBS'
-export * from './OSC'
-export * from './VMix'
-export * from './Hyperdeck'
-export * from './TCPSend'
-export * from './TriCaster'
+export * from './metadata.js'
+export * from './Atem.js'
+export * from './CasparCG.js'
+export * from './HTTPSend.js'
+export * from './OBS.js'
+export * from './OSC.js'
+export * from './VMix.js'
+export * from './Hyperdeck.js'
+export * from './TCPSend.js'
+export * from './TriCaster.js'

shared/packages/models/src/metadata/metadata.ts

@@ -1,12 +1,12 @@
-import { AtemMetadata } from './Atem'
-import { CasparCGMetadata } from './CasparCG'
-import { HTTPSendMetadata } from './HTTPSend'
-import { HyperdeckMetadata } from './Hyperdeck'
-import { OBSMetadata } from './OBS'
-import { OSCMetadata } from './OSC'
-import { TCPSendMetadata } from './TCPSend'
-import { TriCasterMetadata } from './TriCaster'
-import { VMixMetadata } from './VMix'
+import { AtemMetadata } from './Atem.js'
+import { CasparCGMetadata } from './CasparCG.js'
+import { HTTPSendMetadata } from './HTTPSend.js'
+import { HyperdeckMetadata } from './Hyperdeck.js'
+import { OBSMetadata } from './OBS.js'
+import { OSCMetadata } from './OSC.js'
+import { TCPSendMetadata } from './TCPSend.js'
+import { TriCasterMetadata } from './TriCaster.js'
+import { VMixMetadata } from './VMix.js'
 
 export type MetadataAny =
 	| AtemMetadata

shared/packages/models/src/resource/Atem.ts

@@ -1,4 +1,4 @@
-import { ResourceBase, ResourceType } from './resource'
+import { ResourceBase, ResourceType } from './resource.js'
 
 export type AtemAny =
 	| AtemMe

shared/packages/models/src/resource/CasparCG.ts

@@ -1,4 +1,4 @@
-import { ResourceBase, ResourceType } from './resource'
+import { ResourceBase, ResourceType } from './resource.js'
 import type { GDDSchema } from 'graphics-data-definition'
 
 export type CasparCGAny = CasparCGServer | CasparCGMedia | CasparCGTemplate

shared/packages/models/src/resource/HTTPSend.ts

@@ -1,4 +1,4 @@
-import { ResourceBase, ResourceType } from './resource'
+import { ResourceBase, ResourceType } from './resource.js'
 
 export type HTTPSendAny = HTTPRequest
 

shared/packages/models/src/resource/Hyperdeck.ts

@@ -1,4 +1,4 @@
-import { ResourceBase, ResourceType } from './resource'
+import { ResourceBase, ResourceType } from './resource.js'
 
 export type HyperdeckAny = HyperdeckPlay | HyperdeckRecord | HyperdeckPreview | HyperdeckClip
 

shared/packages/models/src/resource/OBS.ts

@@ -1,4 +1,4 @@
-import { ResourceBase, ResourceType } from './resource'
+import { ResourceBase, ResourceType } from './resource.js'
 
 export type OBSAny = OBSScene | OBSTransition | OBSRecording | OBSStreaming | OBSSourceSettings | OBSMute | OBSRender
 

shared/packages/models/src/resource/OSC.ts

@@ -1,4 +1,4 @@
-import { ResourceBase, ResourceType } from './resource'
+import { ResourceBase, ResourceType } from './resource.js'
 
 export type OSCAny = OSCMessage
 

shared/packages/models/src/resource/TCPSend.ts

@@ -1,4 +1,4 @@
-import { ResourceBase, ResourceType } from './resource'
+import { ResourceBase, ResourceType } from './resource.js'
 
 export type TCPSendAny = TCPRequest
 

shared/packages/models/src/resource/TriCaster.ts

@@ -1,4 +1,4 @@
-import { ResourceBase, ResourceType } from './resource'
+import { ResourceBase, ResourceType } from './resource.js'
 
 export type TriCasterAny =
 	| TriCasterMe

shared/packages/models/src/resource/VMix.ts

@@ -1,4 +1,4 @@
-import { ResourceBase, ResourceType } from './resource'
+import { ResourceBase, ResourceType } from './resource.js'
 
 export type VMixAny =
 	| VMixInput

shared/packages/models/src/resource/index.ts

@@ -1,10 +1,10 @@
-export * from './Atem'
-export * from './CasparCG'
-export * from './OBS'
-export * from './VMix'
-export * from './OSC'
-export * from './HTTPSend'
-export * from './Hyperdeck'
-export * from './resource'
-export * from './TCPSend'
-export * from './TriCaster'
+export * from './Atem.js'
+export * from './CasparCG.js'
+export * from './OBS.js'
+export * from './VMix.js'
+export * from './OSC.js'
+export * from './HTTPSend.js'
+export * from './Hyperdeck.js'
+export * from './resource.js'
+export * from './TCPSend.js'
+export * from './TriCaster.js'