Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exports to the CDN and make sure that can't create to more than one room at a time. #197

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

carlossantos74
Copy link
Contributor

@carlossantos74 carlossantos74 commented Jan 6, 2025

Enhancements to Room class:

  • Ensured subscriptions and observers are safely unsubscribed using optional chaining (packages/room/src/core/index.ts).
  • Cleared the window.SUPERVIZ_ROOM property when the room is left (packages/room/src/core/index.ts).

Updates to createRoom function:

  • Added a check to return an existing room instance if one already exists in the window object, with a warning message (packages/room/src/index.ts). [1] [2]
  • Exported createRoom and room-related events to the window object for easier access in a browser environment (packages/room/src/index.ts).

Test enhancements:

  • Added test cases to ensure proper room initialization and handling of existing room instances (packages/room/src/index.test.ts). [1] [2]
  • Ensured room.leave() is called after each test to clean up (packages/room/src/index.test.ts). [1] [2]

Copy link

github-actions bot commented Jan 6, 2025

test: Run #278

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
31 31 0 0 0 0 0 8.4s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 6, 2025

test: Run #278

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
135 135 0 0 0 0 0 9.9s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 6, 2025

test: Run #278

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
71 71 0 0 0 0 0 7.9s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 6, 2025

test: Run #278

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
746 746 0 0 0 0 0 23.0s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 6, 2025

LCOV Report - SDK Web Components Test Coverage Report ✅

All Files

  • Lines: 6230/6424 (97.0%) ✅ (Minimum coverage is 0%)
  • Functions: 304/319 (95.3%)
  • Branches: 610/693 (88.0%)

Changed Files

N/A

Copy link

github-actions bot commented Jan 6, 2025

test: Run #279

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
71 71 0 0 0 0 0 8.1s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 6, 2025

test: Run #279

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
135 135 0 0 0 0 0 10.1s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 6, 2025

test: Run #279

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
34 34 0 0 0 0 0 8.8s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 6, 2025

test: Run #279

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
746 746 0 0 0 0 0 23.3s

🎉 All tests passed!

@carlossantos74 carlossantos74 force-pushed the feat/new-room-oackage-params branch from 80ef952 to 48d5096 Compare January 6, 2025 13:25
Copy link

github-actions bot commented Jan 6, 2025

test: Run #280

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
34 34 0 0 0 0 0 8.4s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 6, 2025

test: Run #280

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
71 71 0 0 0 0 0 8.2s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 6, 2025

test: Run #280

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
135 135 0 0 0 0 0 10.6s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 6, 2025

test: Run #280

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
746 746 0 0 0 0 0 23.2s

🎉 All tests passed!

@carlossantos74 carlossantos74 marked this pull request as ready for review January 6, 2025 13:30
@carlossantos74 carlossantos74 merged commit aeddca3 into lab Jan 6, 2025
6 checks passed
@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/socket-client/1.15.0-lab.3 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/sdk/6.9.0-lab.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/yjs/1.1.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/react/1.16.0-lab.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/autodesk/1.23.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/matterport/1.3.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/three/1.3.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/socket-client/1.15.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/sdk/6.9.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/yjs/1.1.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/autodesk/1.23.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/matterport/1.3.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/three/1.3.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/react/1.16.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/socket-client/1.15.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/sdk/6.9.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/yjs/1.1.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/autodesk/1.23.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/matterport/1.3.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/three/1.3.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/react/1.16.0 🎉

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants