Added commands for order #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negodyaj
reviewed
Jan 10, 2022
|
|
||
| namespace Alligator.DataLayer.Repositories | ||
| { | ||
| public abstract class BaseRepository | ||
| { | ||
| private const string _connection = "Data Source=80.78.240.16;Database=AggregatorAlligator;User Id=student;Password=qwe!23;"; | ||
|
|
||
| protected static SqlConnection ProvideConnection() => new SqlConnection(_connection); | ||
| public static SqlConnection ProvideConnection() => new SqlConnection(_connection); |
There was a problem hiding this comment.
поменяй обратно на протектед
| @@ -8,7 +8,7 @@ public interface IOrderRepository | |||
| { | |||
| int AddOrder(DateTime date, int clientId, string address); | |||
| void DeleteOrder(int id); | |||
| void EditOrder(DateTime date, int id, string address); | |||
| void EditOrder(DateTime date, int orderId, int clientId, string address); | |||
There was a problem hiding this comment.
а объект ордера передать не судьба?)
| return; | ||
| List<OrderDetailModel> orderDetails = new List<OrderDetailModel>(); | ||
|
|
||
| _viewModel.NewOrder.OrderDetails = orderDetails; |
There was a problem hiding this comment.
а нельзя было написать _viewModel.NewOrder.OrderDetails =new List();
?
There was a problem hiding this comment.
в одну строчку, в общем)
| MessageBox.Show("Ошибка при добавлении заказа в базу данных", "Ошибка", MessageBoxButton.OK, MessageBoxImage.Error); | ||
| return; | ||
| } | ||
| else |
There was a problem hiding this comment.
else можно просто убрать и писать код дальше без такого шикарного отступа
| foreach (var orderDetail in _viewModel.NewOrderDetails) | ||
| { | ||
| _orderDetailService.AddOrderDetailModel(orderDetail.Amount, orderId, orderDetail.Product.Id); | ||
| } |
There was a problem hiding this comment.
вот эти два форыча нужно перекинуть в метод сервиса
| @@ -25,9 +26,15 @@ public override void Execute(object parameter) | |||
| { | |||
|
|
|||
| _viewModel.AllOrders.Clear(); | |||
| foreach (var order in _orderService.GetOrders()) | |||
| if (_orderService.GetOrders().Success is true) | |||
There was a problem hiding this comment.
то же самое, что и if (_orderService.GetOrders().Success)
| _viewModel.ChangedDate = _viewModel.SelectedOrder.Date; | ||
| _viewModel.ChangedAddressText = _viewModel.SelectedOrder.Address; | ||
| _viewModel.Clients.Clear(); | ||
| if (_clientService.GetAllClients().Success is true) |
There was a problem hiding this comment.
if (_clientService.GetAllClients().Success)
Breslavchik
requested review from
Svyatopes and
Negodyaj
and removed request for
Negodyaj and
Svyatopes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.