HCX-990 : Configure notifications for revoked certificates #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshkumargangula
requested changes
Feb 16, 2024
hcx-apis/src/main/java/org/swasth/hcx/service/ParticipantService.java
Outdated
Show resolved
Hide resolved
Comment on lines
60
to
65
| if (participant.containsKey(Constants.ENCRYPTION_CERT)) { | ||
| certificatePath = (String) participant.get(Constants.ENCRYPTION_CERT); | ||
| } | ||
| if (participant.containsKey(Constants.SIGNING_CERT_PATH)) { | ||
| certificatePath = (String) participant.get(Constants.SIGNING_CERT_PATH); | ||
| } |
There was a problem hiding this comment.
How it works when both the certificates exist for the participant?
Comment on lines
56
to
57
| List<String> revokedParticipantCodes = new ArrayList<>(); | ||
| List<String> invalidCertificates = new ArrayList<>(); |
There was a problem hiding this comment.
Avoid using a mutable list like this. It creates problem and won't be able to understand what are all the places the list is updating.
Co-authored-by: Mahesh Kumar Gangula <[email protected]>
…ce.java Co-authored-by: Mahesh Kumar Gangula <[email protected]>
…iGaddi/hcx-platform into certificate-revoke-schedular
|
maheshkumargangula
approved these changes
Mar 12, 2024
maheshkumargangula
merged commit 0f3388b
into
Swasth-Digital-Health-Foundation:sprint-55
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains
— Add validate certificate revocation status logic in hcx-commons
— Certificate revocation scheduler
— Update the status to Inactive for participant revoked certificate