Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make naga oil's error more useful #6

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

Swoorup
Copy link
Owner

@Swoorup Swoorup commented Feb 25, 2024

Make it appear nicer when the naga oily compiler fails.

--- stderr
  Error:   × Failed to compose modules with entry `src/shader/testbed.wgsl`
    │ error: failed to build a valid final module: Global variable [13]'scene_transform' is invalid
    │    ┌─ src/shader/testbed.wgsl:76:23
    │    │
    │ 76 │ @group(1) @binding(2) var<uniform> scene_transform:SceneTransformData;
    │    │                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    │ naga::GlobalVariable [13]
    │    │
    │    = Alignment requirements for address space Uniform are not met by [40]
    │    = The struct member[1] offset 8 must be at least 16
    │ 
    │ 

[Finished running. Exit status: 101]

Hit another issue though
bevyengine/naga_oil#78

@Swoorup Swoorup merged commit 6a1bc45 into main Feb 25, 2024
@Swoorup Swoorup deleted the sj-improve-naga-oil-messages branch February 25, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants