Fix AE2 Grinder Recipe + BoP Mud Recipe Cleanup #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR majorly solves the issue that AE2 grinder recipes for ores in very early game is wrong for the ones yielding more than 1 crushed ore when hammering. Previously, all recipe is 2 ores ---5 rotation--> 3 crushed ores. Now, they take into account of
oreMultiplier. For example, lapis is now 2 ores --> 18 crushed ores, which is 1.5x boost. For reference, hammering and macerating lapis ore yields 6 and 12, respectively. Grinding coal deposit is also changed into 2 blocks yielding 16 dusts, since any existing method yields 8 per deposit block. Salt deposits remained unchanged.Also, BoP dirt + water = mud recipe duplication is also resolved. Originally, there is a file adding the shaped recipe and another adding shapeless recipe. These two are unified into the same place (keeping only the shapeless one).
Implementation Details
Only some lines in the groovy script is changed. The implementation is quite straight forward.
Outcome
Fixes https://discord.com/channels/881234100504109166/1334026508506890240
The link contains a list of ores that should be affected by this fix.
Potential Compatibility Issues
Nothing as far as I am aware.