Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup dx7 synth properly when setup via osc type menu #3012

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 3, 2024

follow up to #3004

  • only setup dx7 on source1.
  • the ENV1 release should be set to 50 to let the DX7:s internal envelopes release phase play out (yes, we still do voice culling properly when the dx7 envelopes end)
  • The VEL-> master volume patch cable should not be used as dx7 handles velocity per operator and this additional global patch cable will throw off loaded patches which are properly velocity calibrated internally.

follow up to #3004

This restriction was intentional as the UI code (like the operator
sidebar) assumes only OSC1 is used as a DX7 oscillator.

We might want to improve the UI later on, but for now keep the
restriction
@github-actions github-actions bot added cherry-pick Commit to cherry pick to release branch cherry-picked PR generated by cherry pick action labels Dec 3, 2024
@seangoodvibes seangoodvibes reopened this Dec 3, 2024
Copy link
Contributor Author

github-actions bot commented Dec 3, 2024

Test Results

103 tests   103 ✅  0s ⏱️
 15 suites    0 💤
 15 files      0 ❌

Results for commit 8078cd9.

@seangoodvibes seangoodvibes merged commit b7a24df into release/1.2 Dec 3, 2024
6 checks passed
@stellar-aria stellar-aria deleted the cherry-pick-release/1.2-24ef1dbce7917423d1796cc2397d1d51d92dc107 branch December 10, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick Commit to cherry pick to release branch cherry-picked PR generated by cherry pick action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants