This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 3
Remove shared lib byte code files from source code & use GitHub Pipeline to build #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
July 25, 2024 12:57
KendallWeihe
changed the title
Kendall/GitHub mvn repo
Remove shared lib byte code files from source code & use GitHub Pipeline to build
Jul 25, 2024
I see the |
this brings it home to me, basically exactly as @ALRubinger was discussing |
Closing in favor of #96 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this PR to a Draft because I'm not entirely sure we should move forward with everything -- @nitro-neal @ALRubinger @leordev I'm hoping this can be a collaborative space.
As what is currently in
main
, in order to publish a new Kotlin lib we must:bindings/tbdex_uniffi/libtargets/
This is undesirable for several reasons:
groupId
andartifactId
Note
With regards to that last bullet point, configuring the values in JitPack may be possible but would require a much more involved solution, which negates the value proposition of JitPack which is that it's simple, easy and "just works." JitPack automatically sets
<groupId>com.github.TBD54566975</groupId>
and<artifactId>tbdex-rs</artifactId>
but that's undesirable, even as a temporary measure because it's "Rust." This is not a show stopper, but would be nice to fix.And so, the original intent of this work was to alleviate those three undesirable bullet points.
Changes
.github/workflows/publish-kt.yml
.gitignore
bound/kt/README.md
to instruct local developers to first execute their bindingbound/kt/pom.xml
Add
.github/workflows/publish-kt.yml
This is where most of the action is, and so I would imagine even if we don't move forward with this PR then we may pull this Workflow code out of this branch and use it in future work.
Here is a visual of the workflow:
The sequence of events goes:
main
branchpush
events, but the last workflow run wherein this executed is here)Proposal
@ALRubinger @leordev @nitro-neal I know that GitHub Packages is not our solution for Maven hosting, and so I see one of two ways forward:
A. We do not merge this, but we use a lot of the code changes here (copy/paste + massage into place) in what will be our long term solution.
B. We alleviate the 401 issue in the consumption of the GitHub Package Maven artifact and we move forward with this as a one-step-closer to where we want to be.