NV12 UI

[satgit62]

NV12 settings selection added

In the new hyperion-webos, the backends have been extended to include nv12 video format, so that NV12/YUV can also be passed on to the Hyperion or HyperHDR instead of RGB.
As a result, I have added a NV12 selection checkbox to the UI. In addition, hyperion-webos submodules would have to be linked to the latest https://github.com/webosbrew/hyperion-webos.

[Dak0r]

Hey, code looks good to me. I built it locally and seems to work, with the correct version of the webos backend.
Any reason, why you didn't include the submodule update in this branch? In my opinion, it's a requirement to merge this.

I am not sure, if we want to mention somewhere that HyperHDR v21 is required for this, as it won't work with the current v20 stable release?

[Dak0r]

Because the hyperhdr stable release (v20) does not support it, yet, defaulting to false would be a more fitting default for now, imo

[TBSniller]

Would agree on that. In backend service it also defaults to false: https://github.com/webosbrew/hyperion-webos/blob/main/src/settings.c#L19

[satgit62]

Hey, code looks good to me. I built it locally and seems to work, with the correct version of the webos backend. Any reason, why you didn't include the submodule update in this branch? In my opinion, it's a requirement to merge this.

I am not sure, if we want to mention somewhere that HyperHDR v21 is required for this, as it won't work with the current v20 stable release?

Hello,
I originally assigned the submodules from @sundermann, but there were errors when compiling, and so I removed them again, hoping @TBSniller would comment.
See: https://github.com/satgit62/piccap/tree/nv12
In the end, I swapped the backends manually.

[Dak0r]

I was able to build your piccap branch with the submodule updated to the latest main branch commit from sundermann, without problems. Which error did you get?

(Note: I had to update cmake in my WSL to >=3.24, because hyperion-webos is now using DOWNLOAD_EXTRACT_TIMESTAMP in its CMakeFile)

[satgit62]

I was able to build your piccap branch with the submodule updated to the latest main branch commit from sundermann, without problems. Which error did you get?

(Note: I had to update cmake in my WSL to >=3.24, because hyperion-webos is now using DOWNLOAD_EXTRACT_TIMESTAMP in its CMakeFile)

Yes, if you build on PC it works with cmake update good (hint) but in GitHub when pushing an action the IPK is not built. See: https://github.com/satgit62/piccap/actions/runs/12156806035/job/33901240141

[TBSniller]

The readme looks a bit strange with this comment.
Maybe move it with its explaination here https://github.com/TBSniller/piccap?tab=readme-ov-file#advanced-settings ?

[TBSniller]

I'm sorry I was quite inactive and haven't followed the new changes.
How big is this new feature? Does it make sense to be on the main settings page, or has it a better place in a seperate section on the advanced settings page?
I think it would be the best to leave the main settings page as simple as possible

[TBSniller]

Would also suggest to rename the label to uppercase NV12 instead of nv12.

[TBSniller]

If we bump hyperion-webos submodule we could also go to 0.5.0

[TBSniller]

Thank you very much for contribution!
As the new hyperion-webos version is needed for NV12 support, I think there is also a need to bump the submodule to latest version

[satgit62]

Thank you very much for contribution! As the new hyperion-webos version is needed for NV12 support, I think there is also a need to bump the submodule to latest version

Hi @TBSniller,
yes, I also think it is very good to update the submodules and update the PicCap version to 5.0. Thanks a lot for that.