Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NV12 #90

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

NV12 #90

wants to merge 36 commits into from

Conversation

satgit62
Copy link

@satgit62 satgit62 commented Dec 29, 2024

Selection of NV12 settings added

In the new hyperion-webos, the NV12 video format has been added to the backends so that NV12/YUV can also be passed to the Hyperion or HyperHDR instead of RGB.
As a result, I added an NV12 selection box to the user interface. I also linked the Hyperion Webos submodules to the latest https://github.com/webosbrew/hyperion-webos.

PicCap_UI_nv12

README.md Outdated
# PicCap - Hyperion Sender App | Ambilight for LG WebOS TVs
# PicCap - Hyperion Sender App | Ambilight for LG WebOS TVs

Selection of NV12 settings added
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose to either remove this line from the README, or add a dedicated changelog section which lists this as the change for version 0.5.0.

So far the changes were documented per release, so I'd be in favor of just removing it here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint, I have removed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick - looks good!

@satgit62
Copy link
Author

@Dak0r
With the changes of the TOOLCHAIN location in the build_piccap.yml and in the package.json everything was compiled correctly. See: https://github.com/satgit62/piccap/actions/runs/12904947120

@TBSniller
Copy link
Owner

Do you mind answering the question from previous PR, as I'm not so familiar with latest changes? :)

How big is this new feature? Does it make sense to be on the main
settings page, or has it a better place in a seperate section on the advanced settings page?
I think it would be the best to leave the main settings page as simple as possible

@satgit62
Copy link
Author

satgit62 commented Jan 22, 2025

think it would be the best to leave the main settings page as simple as possible

@TBSniller
Hello,
The new backends allow direct recording of the NV12 stream and pass the pure NV12 stream on to HyperHDR or Hyperion.NG. Since no conversion to RGB is necessary, the colour representation is almost perfect.
The new backends also allow the use of different LUT tables in HyperHDR, e.g. for SDR, HDR and Dolby Vision.

   #define LUT_TABLE_FILENAME_HDR “lut_lin_tables_hdr.3d”
   #define LUT_TABLE_FILENAME_DV “lut_lin_tables_dv.3d”
   #define LUT_TABLE_FILENAME_SDR “lut_lin_tables.3d”

NV12 was used by @awawa-dev in HyperHDR and by @Lord-Grey in Hyperion.NG.
Placing it on the settings page makes sense as most users will look at it and very few will go to the advanced settings.

Thank you in advance.

@TBSniller
Copy link
Owner

Alright, thanks for the clarification!

If you are done with this PR, I will test it till the end of the week

@satgit62
Copy link
Author

satgit62 commented Jan 22, 2025

Alright, thanks for the clarification!

If you are done with this PR, I will test it till the end of the week

@TBSniller
Thanks, I've already tested it, and it works as it should. I will not make any changes and am done with the PR.
I'm already looking forward to the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants