-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing makefile bugs and typo #55
Open
arno1820
wants to merge
2
commits into
TECHS-Technological-Solutions:develop
Choose a base branch
from
arno1820:improvements-to-make-file
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fixing makefile bugs and typo #55
arno1820
wants to merge
2
commits into
TECHS-Technological-Solutions:develop
from
arno1820:improvements-to-make-file
+233
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add basic structure * feat: add few ocpi data types * feat: add data types * feat: add version module enums and schemas * feat: add basic versions module * feat: add versions details endpoint * refactor: modify VersionNumber enum * feat: add locations module, crud and adaptor * chore: update prospector config * refactor: adaptor * refactor: adaptor * chore: update readme * feat: make crud and adapter dependency, add example * refactor: import core enums and datatypes to source module * refactor: make routers and CRUD methods asycn * fix: linter * fix: update schema definitions * fix: update schema definitions * chore: add pypi publish workflow * refactor: change project name to py_ocpi * Update README.md * refactor: get prefix from env * refactor: change HOST to OCPI_HOST * feat: add pagination for list endpoints * fix: add id param to update method of crud * Update README.md * Rename README.md to README.rst * Update README.rst * Update pyproject.toml * OCPI-55 (TECHS-Technological-Solutions#7) * feat: add sessions module schemas and enums * feat: add sessions module schemas and enums * feat: add sessions endpoints * OCPI-48 (TECHS-Technological-Solutions#3) * feat: add schemas and enums for credentials module * fix: pylint fix * feat: add credentials module * fix: PR review changes * feat: make crud funtions in credentials endpoint async * fix: change verification params * feat: add cdrs schemas and enums (TECHS-Technological-Solutions#10) * feat: add cdrs endpoints, refactor code enums, move universal files to core (TECHS-Technological-Solutions#11) * OCPI-48 (TECHS-Technological-Solutions#15) * feat: update authorization process * fix: pylint fix * feat: add exception handlder * fix: pylint, add middleware fix * feat: add all test modules (TECHS-Technological-Solutions#17) * feat: change post credentials url * feat: modify commands module cpo (TECHS-Technological-Solutions#18) * OCPI-66 (TECHS-Technological-Solutions#22) * feat: improve crud and adapter, improve OCPI version management * refactor: add routers and modules directories * Fix the router URLs (TECHS-Technological-Solutions#36) * Fix the router URLs * Fix versions and details URLs * fix: return version details based on role (TECHS-Technological-Solutions#39) * Use dict type instead of list for details endpoint (TECHS-Technological-Solutions#40) * Fix the initial authentication (TECHS-Technological-Solutions#43) * Base64 encode the bearer token * Decode the base64 encoded authentication token * Require authorization when listing versions * Revert "Fix the initial authentication (TECHS-Technological-Solutions#43)" (TECHS-Technological-Solutions#44) This reverts commit a40dc0d. * Update push.yaml * Fix initial credentials exchange (TECHS-Technological-Solutions#46) * Fix the initial authentication (TECHS-Technological-Solutions#43) * Base64 encode the bearer token * Decode the base64 encoded authentication token * Require authorization when listing versions * Remove the list wrapping the credentials object * Fix tests * Skip false positive Bandit test B105 * Ignore false positive * Fix linter error * feat: make new version 0.3.1 --------- Co-authored-by: Hamed Akhavan <[email protected]> Co-authored-by: ViCt0r99 <[email protected]> Co-authored-by: ViCt0r99 <[email protected]> Co-authored-by: Wojtek Siudzinski <[email protected]>
@arno1820 please rebase to develop |
Hello @arno1820, |
@arno1820 we will soon merge the request, have you anything to add as we add a lot of improvements recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I propose the following fixes in the makefile of the project.