fix(feed): Fix Tip action and TipModal #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix refresh Tip Fix error uncontrolled input Remove legacy stuff Close properly Tip Modal and prevent unstoppable loading
WaDadidou
requested review from
hthieu1110,
n0izn0iz,
omarsy,
Villaquiranm and
MikaelVallenet
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was
linked to
issues
Nov 18, 2024
Closed
n0izn0iz
requested changes
Nov 18, 2024
n0izn0iz
requested changes
Nov 18, 2024
There was a problem hiding this comment.
I have a full app crash when a decimal number (like 0.42) is entered as tip amount, it's not present on main
Error: Fractional part missing
at _e.TipModal (https://deploy-preview-1387--teritori-dapp.netlify.app/_expo/static/js/web/AppEntry-365ba3edc76685e54f8abeac0296fa69.js:3706:1087)
at _e.TipButton (https://deploy-preview-1387--teritori-dapp.netlify.app/_expo/static/js/web/AppEntry-365ba3edc76685e54f8abeac0296fa69.js:3705:1495)
at div
at https://deploy-preview-1387--teritori-dapp.netlify.app/_expo/static/js/web/AppEntry-365ba3edc76685e54f8abeac0296fa69.js:603:1621
at div
at https://deploy-preview-1387--teritori-dapp.netlify.app/_expo/static/js/web/AppEntry-365ba3edc76685e54f8abeac0296fa69.js:603:1621
at e.FlexRow (https://deploy-preview-1387--teritori-dapp.netlify.app/_expo/static/js/web/AppEntry-365ba3edc76685e54f8abeac0296fa69.js:3247:260)
at e.SocialCardFooter (https://deploy-preview-1387--teritori-dapp.netlify.app/_expo/static/js/web/AppEntry-365ba3edc76685e54f8abeac0296fa69.js:5133:328)
at div
hthieu1110
reviewed
Nov 18, 2024
|
MikaelVallenet
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "Cannot tip"
Closes #1376
Gno network: https://github.com/TERITORI/teritori-dapp/blob/fix-tip/packages/components/socialFeed/SocialActions/TipModal.tsx#L119
Other networks: https://github.com/TERITORI/teritori-dapp/blob/fix-tip/packages/components/socialFeed/SocialActions/TipModal.tsx#L159
Fixes "the Tip amount is not refresh"
Closes #1389
https://github.com/TERITORI/teritori-dapp/blob/fix-tip/packages/components/socialFeed/SocialActions/TipModal.tsx#L90
Fixes a wrong Tip amount shown
tipAmountwas astringhere, so theaddedAmountaddition results on a broken number displayedhttps://github.com/TERITORI/teritori-dapp/blob/fix-tip/packages/hooks/feed/usePost.ts#L74
I used the same pattern as here: https://github.com/TERITORI/teritori-dapp/blob/fix-tip/packages/utils/social-feed.ts#L123
Fixes this loader that won't stop if the TX fails (Gno Tip also)
https://github.com/TERITORI/teritori-dapp/blob/fix-tip/packages/components/socialFeed/SocialActions/TipModal.tsx#L91
Fixes closing the TipModal, even if Tip fails, to let the Toast Error visible (Gno Tip also)
https://github.com/TERITORI/teritori-dapp/blob/fix-tip/packages/components/socialFeed/SocialActions/TipModal.tsx#L90
Fixes this error
https://github.com/TERITORI/teritori-dapp/blob/fix-tip/packages/components/socialFeed/SocialActions/TipModal.tsx#L58-L60