add AddressesServiceProvider to the testCase #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com:tipoff/feedback into wolfrednicolas/feature/add-addresses-to-testCase
chx2
reviewed
Mar 10, 2021
| @@ -29,6 +29,7 @@ public function email() | |||
|
|
|||
| return $mail->feedback->id === $feedback->id && | |||
| $mail->hasFrom($feedback->location->contact_email, $feedback->location->title) && | |||
| //Todo: require Bookings | |||
There was a problem hiding this comment.
TIPOFF/bookings#47 is blocking this since $feedback->participant->email depends on the Participant model email field.
chx2
reviewed
Mar 10, 2021
| @@ -40,13 +40,7 @@ public function data_provider_for_all_permissions_as_creator() | |||
| { | |||
| return [ | |||
| 'view-true' => [ 'view', self::createPermissionedUser('view feedbacks', true), true ], | |||
| 'view-false' => [ 'view', self::createPermissionedUser('view feedbacks', false), false ], | |||
There was a problem hiding this comment.
Since I'm assuming Feedback should only be viewed, would any of these checks be required?
…omnia/feature/38-Create-Permissions
Create permissions for feedback
drewroberts
deleted the
wolfrednicolas/feature/add-addresses-to-testCase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.