Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noise suppression support for rule yeetUpdateSuppressionCrash #165

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

VelizarBG
Copy link
Contributor

For context (if needed): noise suppression has been released.
I'm gonna leave backporting to you since you know your setup better than I do.

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
carpet-tis-addition ✅ Ready (Inspect) Visit Preview Aug 7, 2024 7:27pm

@Fallen-Breath
Copy link
Contributor

Nice. Are these 2 @WrapOperation targets the only places where the blockEntity-blockState mismatch will happen for the sculk sensor IllegalArgumentException suppression thing?

@Fallen-Breath Fallen-Breath added the enhancement New feature or request label Aug 6, 2024
@VelizarBG
Copy link
Contributor Author

Yep, at least according to what I could find.

@Fallen-Breath
Copy link
Contributor

Yep, at least according to what I could find.

Just a quick view, other blocks like sculk shrieker have similiar codes in net.minecraft.block.entity.SculkShriekerBlockEntity.VibrationCallback#accepts, maybe they are exploitable as well?

has not been tested in game yet
@VelizarBG
Copy link
Contributor Author

I don't think the others are useful. The sculk shrieker BE only accepts the SCULK_SENSOR_TENDRILS_CLICKING game event and that one can only be emitted during the BE tick, making it only useful for crashing a server. The sculk catalyst can suppress only living entity death but you need to hook it up to an existing suppressor anyway.

@Fallen-Breath
Copy link
Contributor

Fair. Just wait until other IEA application scenarios emerge. cuz if we patch it directly at net.minecraft.state.State#get, the potential impact will be too large

@Fallen-Breath Fallen-Breath merged commit ca19e40 into TISUnion:master Aug 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants