Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] S3 연동 및 이미지 업로드 기능 구현 #23

Merged
merged 3 commits into from
Jan 15, 2025
Merged

[FEATURE] S3 연동 및 이미지 업로드 기능 구현 #23

merged 3 commits into from
Jan 15, 2025
+151 −6

Conversation

m020202
Copy link
Contributor

@m020202 m020202 commented Jan 14, 2025

Issue

Summary

  • S3 연동 및 이미지 업로드 & 삭제 기능 구현.

Describe your code

Check

  • Reviewers 등록을 하였나요?
  • Assignees 등록을 하였나요?
  • 라벨 등록을 하였나요?
  • PR 머지하기 전 반드시 CI가 정상적으로 작동하는지 확인해주세요!

@m020202 m020202 added the ✨ feat 기능 추가 label Jan 14, 2025
@m020202 m020202 self-assigned this Jan 14, 2025
@m020202 m020202 linked an issue Jan 14, 2025 that may be closed by this pull request
[FEATURE] S3 연동 및 이미지 업로드 기능 구현 #22
Closed
ahtop00
ahtop00 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@ahtop00 ahtop00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 연동 및 기능 구현 고생하셨습니다!! 😄 푸시 알람 쪽에도, 음악을 S3를 통해 추가하고 URL을 저장해야 해서, 이 부분은 PR이 머지 되고나서, 제가 이슈 작성 후 추가 기능 구현하도록 하겠습니다!

@m020202 m020202 merged commit 999ad77 into develop Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahtop00 ahtop00 ahtop00 approved these changes

@yunsful yunsful Awaiting requested review from yunsful

@choiao0 choiao0 Awaiting requested review from choiao0

@seoyeoneel02 seoyeoneel02 Awaiting requested review from seoyeoneel02

Assignees

@m020202 m020202

Labels
✨ feat 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] S3 연동 및 이미지 업로드 기능 구현
2 participants
@m020202 @ahtop00