Skip to content

Commit

Permalink
Fix offline package script
Browse files Browse the repository at this point in the history
pip installation was missing
the same requirements file was executed twice

Signed-off-by: Florian Esser <[email protected]>
  • Loading branch information
florianesser-tng committed Nov 25, 2024
1 parent 71a6411 commit 5db0658
Showing 1 changed file with 20 additions and 1 deletion.
21 changes: 20 additions & 1 deletion WebUI/build/scripts/pack-offline.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,22 @@ function unzippedPackagedPyenv(pyenvArchive) {
return offlineEnvDir
}

function installPip(getPipFilePath, workingDir) {
const runGetPip = spawn(pythonExe, [getPipFilePath], { cwd: workingDir });
runGetPip.stdout.on('data', (data) => {
console.log(data.toString());
});
runGetPip.stderr.on('data', (data) => {
console.error(data.toString());
});
pipInstall.on('close', (code) => {
if (code !== 0) {
console.error('Failed to install pip');
process.exit(1);
}
});
}

function runPipInstall(requirementsFilePath, workingDir) {
const pipInstall = spawn(pythonExe, ['-m', 'pip', 'install', '-r', requirementsFilePath], { cwd: workingDir });
pipInstall.stdout.on('data', (data) => {
Expand Down Expand Up @@ -81,8 +97,11 @@ function main() {
const offlineEnvDir = unzippedPackagedPyenv(zippedPyenv)
const pythonExe = existingFileOrExit(path.join(offlineEnvDir, 'python.exe'));

const getPipFile = existingFileOrExit(path.join(offlineEnvDir, 'get-pip.py'));
const platformSpecificRequirementsTxt = existingFileOrExit(path.join(__dirname, '..', '..', 'service', `requirements-${platform}.txt`));
const requirementsTxt = existingFileOrExit(path.join(__dirname, '..', '..', 'service', `requirements-${platform}.txt`));
const requirementsTxt = existingFileOrExit(path.join(__dirname, '..', '..', 'service', `requirements.txt`));

installPip(getPipFile, offlineEnvDir)
runPipInstall(platformSpecificRequirementsTxt, offlineEnvDir)
runPipInstall(requirementsTxt, offlineEnvDir)

Expand Down

0 comments on commit 5db0658

Please sign in to comment.