Fix/pressreleasebuild #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianesser-tng
commented
Nov 29, 2024
florianesser-tng
commented
- added note to addCustomLLMDialog hinting to potential unsupported models
- fixed bug in doesHuggingFaceRepo/File exist in the case of single file downloading
- added check for model existence for models declared in comfyUI workflows
- disabled generation parameter button for comfyUI generated pictures, while we are settling for what settings to display
- adjusted file paths for opening image and folder of comfyUI generated pictures
- added UI guidance on how to use downloadLLM Dialog
- switched from flask to flaskAPI in backend to enhance working with typed requests
Benefit from types and request validation to make backend more robust and understandable.
Unclear, what settings to display for now
Custom loaded llm models may not have a config.json They might still be downloaded. Hence, exclude from checks. Also: add retry to "move to desired dir" method - this might fail (notoriously on windows with exception:[WinError 5] Access is denied). Unfortunately, this did not solve the problem
quickfix by hardcode. Serverstart receives --output-dir variable Adjust lookup accordingly.
…epositories only / no single-files) Signed-off-by: marijnvg-tng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.