Skip to content

Commit

Permalink
fix applications removing traces redirect
Browse files Browse the repository at this point in the history
Signed-off-by: Adam Tackett <[email protected]>
  • Loading branch information
Adam Tackett committed Jan 8, 2025
1 parent 1b5ab44 commit 2a8d80e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1474,6 +1474,7 @@ exports[`Traces component renders empty traces page 1`] = `
items={Array []}
loading={true}
mode="data_prepper"
page="traces"
refresh={[Function]}
>
<EuiPanel>
Expand Down Expand Up @@ -3930,6 +3931,7 @@ exports[`Traces component renders jaeger traces page 1`] = `
jaegerIndicesExist={true}
loading={true}
mode="jaeger"
page="traces"
refresh={[Function]}
>
<EuiPanel>
Expand Down Expand Up @@ -6217,6 +6219,7 @@ exports[`Traces component renders traces page 1`] = `
items={Array []}
loading={true}
mode="data_prepper"
page="traces"
refresh={[Function]}
>
<EuiPanel>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ export function TracesContent(props: TracesProps) {
openTraceFlyout={openTraceFlyout}
jaegerIndicesExist={jaegerIndicesExist}
dataPrepperIndicesExist={dataPrepperIndicesExist}
page={page}
/>
)}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ interface TracesTableProps {
openTraceFlyout?: (traceId: string) => void;
jaegerIndicesExist: boolean;
dataPrepperIndicesExist: boolean;
page?: 'traces' | 'app';
}

export function TracesTable(props: TracesTableProps) {
Expand Down Expand Up @@ -74,7 +75,9 @@ export function TracesTable(props: TracesTableProps) {
<EuiFlexItem grow={false}>
<EuiLink
data-test-subj="trace-link"
href={appendModeToTraceViewUri(item, getTraceViewUri, traceMode)}
{...(props.page !== 'app' && {
href: appendModeToTraceViewUri(item, getTraceViewUri, traceMode),
})}
{...(openTraceFlyout && { onClick: () => openTraceFlyout(item) })}
>
<EuiText size="s" className="traces-table traces-table-trace-id" title={item}>
Expand Down

0 comments on commit 2a8d80e

Please sign in to comment.