Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add all html color names #263

Closed
wants to merge 1 commit into from

Conversation

BlueFalconHD
Copy link

No description provided.

@coolesding
Copy link

interesting pull request haha, this would definitely require a better way to select colours though, since scrolling through that endless list would be a nightmare

@CyanVoxel
Copy link
Member

While more color options is definitely something we want, I'm afraid this isn't the way to go about it. Not only does this change not function properly, but increasing the number of available colors in the dropdown from ~36 to ~746 would render it extremely difficult to use. Custom user colors is also a feature on the Planned Features list that would supersede the need for a comprehensive list of defaults. Also for the future, providing a description on the pull request of your intentions and changes would be very helpful.

@BlueFalconHD
Copy link
Author

Thank you, I apologize.

@CyanVoxel CyanVoxel added Type: Invalid This doesn't seem right TagStudio: Tags Relating to the TagStudio tag system labels Jun 10, 2024
@CyanVoxel
Copy link
Member

I'll close out this particular PR but I'll be keeping issue #264 open as place to discuss the custom color feature in more detail. I appreciate the time you've put in creating this, and apologize for not being able to help guide the feature given the circumstances.

@CyanVoxel CyanVoxel closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TagStudio: Tags Relating to the TagStudio tag system Type: Invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants