Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solid-js example #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Blankeos
Copy link

@Blankeos Blankeos commented Aug 23, 2024

Summary

  • Added a solid example in the examples/ folder. (though I have no idea how u run this from within the repo besides taking it out and running it), it's pretty tricky with tsconfig's jsx and jsxImportSource conflicting with React's as well.
  • I made a full-blown example here using the same files tho: http://github.com/blankeos/swapy-solid-example

demo

@Blankeos Blankeos force-pushed the feat/example-solid branch from a81dbfc to 4dc0e1b Compare August 23, 2024 21:17
@thedanchez
Copy link

Hey @Blankeos, not sure if you're interested in this, but I went ahead and made a small SolidJS wrapper library for Swapy here: https://github.com/thedanchez/swapy-solid#readme.

Made it to streamline the Swapy experience for SolidJS devs.

@TahaSh
Copy link
Owner

TahaSh commented Dec 15, 2024

Thank you so much for this PR! But can you please update it to follow the new examples in v1.0? For consistency, it's better if it follows the same layout and styles and without a counter; so it's only different in how the framework is used. Take a look at this React example.

@thedanchez
Copy link

Thank you so much for this PR! But can you please update it to follow the new examples in v1.0? For consistency, it's better if it follows the same layout and styles and without a counter; so it's only different in how the framework is used. Take a look at this React example.

@TahaSh Oh nice, completely missed the v1.0 release -- I'll go ahead and update my small wrapper library to streamline the experience a bit further for SolidJS users. Thanks for the work on Swapy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants