refactor: OIDC4VP error management for presentation definition #2029

TalaoDAO · Oct 19, 2023 · 8763027 · 8763027
1 parent 678b094
commit 8763027
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 2 deletions.
diff --git a/lib/dashboard/qr_code/qr_code_scan/cubit/qr_code_scan_cubit.dart b/lib/dashboard/qr_code/qr_code_scan/cubit/qr_code_scan_cubit.dart
@@ -875,6 +875,37 @@ class QRCodeScanCubit extends Cubit<QRCodeScanState> {
       );
     }
 
+    if (presentationDefinition.inputDescriptors.isEmpty) {
+      throw ResponseMessage(
+        data: {
+          'error': 'invalid_request',
+          'error_description':
+              'The input_descriptors is required in the presentation_definition'
+                  ' object',
+        },
+      );
+    }
+
+    if (presentationDefinition.format == null) {
+      throw ResponseMessage(
+        data: {
+          'error': 'invalid_request',
+          'error_description': 'Presentation definition is invalid',
+        },
+      );
+    }
+
+    for (final descriptor in presentationDefinition.inputDescriptors) {
+      if (descriptor.constraints == null) {
+        throw ResponseMessage(
+          data: {
+            'error': 'invalid_request',
+            'error_description': 'Presentation definition is invalid',
+          },
+        );
+      }
+    }
+
     final CredentialManifest credentialManifest = CredentialManifest(
       'id',
       IssuedBy('', ''),

diff --git a/pubspec.lock b/pubspec.lock
@@ -779,10 +779,10 @@ packages:
     dependency: "direct main"
     description:
       name: file_saver
-      sha256: "591d25e750e3a4b654f7b0293abc2ed857242f82ca7334051b2a8ceeb369dac8"
+      sha256: "8ffd91ae9f543c5ebbfec71a814ee5aa9e21176d31335133308abf63f4c42e8a"
       url: "https://pub.dev"
     source: hosted
-    version: "0.2.8"
+    version: "0.2.9"
   file_selector_linux:
     dependency: transitive
     description: