-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add daily reminders for meetups happening today #7
base: master
Are you sure you want to change the base?
Conversation
7c67307
to
fd012cb
Compare
fd012cb
to
b065721
Compare
@chtzvt or @iBotPeaches it would be great to get a review on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to code. I see this runs daily, the weekly job also runs. Should this job ignore Monday so only the weekly job runs?
Or in general - what purpose does the weekly have (outside of pushing to 2 other slacks) if this is daily?
Oh, thanks for asking. Your questions are making me realize I didn't fully think this through.
The weekly job posts all events happening this week. It's basically exactly how the current workflow it set up to post e.g. these messages. The daily will just post events happening today.
No it shouldn't. But it should take some care. I'm thinking on Monday the weekly should run first then the daily. There's something about that solution that seems a bit ick. But since they're posting messages to the same channel, it's what I can think to do right now. |
b065721
to
683b1d9
Compare
@iBotPeaches I went ahead and modified the daily workflow to run 5 minutes past the hour to address this 👍 |
This PR adds the capability to post daily reminders for meetup events happening today to slack:
Daily reminders
Fixes #1
Additional
It also adds the capability to replace the houly 60 minute event reminders in the Tampa Devs slack that are currently going to
#meetup-reminders
to address #4 (though actually replacing those are outside of the scope of this PR), and makes some small tweaks to the weekly event reminders (like posting events happening just this week instead of two weeks out).Usage
The
main.rb
script would now be invoked asruby main.rb [--destinations=<destinations>] [--weekly|--daily |--hourly]
(e.g.ruby main.rb --destinations=TD --daily
to post today's events to just the Tampa Devs slack). By default,ruby main.rb
with no arguments defaults tomain.rb --destinations=TD,TBT,TBUX --weekly
as to maintain backwards compatibility with how the script is currently being invoked.The new workflow
push-events-daily.yml
posts events daily.