Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily reminders for meetups happening today #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ebanner
Copy link
Contributor

@ebanner ebanner commented Sep 17, 2024

This PR adds the capability to post daily reminders for meetup events happening today to slack:

Daily reminders

image

Fixes #1

Additional

It also adds the capability to replace the houly 60 minute event reminders in the Tampa Devs slack that are currently going to #meetup-reminders to address #4 (though actually replacing those are outside of the scope of this PR), and makes some small tweaks to the weekly event reminders (like posting events happening just this week instead of two weeks out).

Usage

The main.rb script would now be invoked as ruby main.rb [--destinations=<destinations>] [--weekly|--daily |--hourly] (e.g. ruby main.rb --destinations=TD --daily to post today's events to just the Tampa Devs slack). By default, ruby main.rb with no arguments defaults to main.rb --destinations=TD,TBT,TBUX --weekly as to maintain backwards compatibility with how the script is currently being invoked.

The new workflow push-events-daily.yml posts events daily.

@ebanner
Copy link
Contributor Author

ebanner commented Sep 17, 2024

There are some minor styling changes to weekly announcements:

image

Just changing the header text to a header type.

I also changed it to show events just this week, as opposed to the next two weeks, and changed the header text to reflect that change.

@ebanner ebanner force-pushed the add-daily-meetup-reminders branch 2 times, most recently from 7c67307 to fd012cb Compare September 17, 2024 16:28
@ebanner ebanner force-pushed the add-daily-meetup-reminders branch from fd012cb to b065721 Compare September 17, 2024 16:30
@ebanner ebanner marked this pull request as draft September 17, 2024 20:01
@ebanner ebanner marked this pull request as ready for review September 18, 2024 20:35
@ebanner
Copy link
Contributor Author

ebanner commented Sep 18, 2024

@chtzvt or @iBotPeaches it would be great to get a review on this.

Copy link

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to code. I see this runs daily, the weekly job also runs. Should this job ignore Monday so only the weekly job runs?

Or in general - what purpose does the weekly have (outside of pushing to 2 other slacks) if this is daily?

@ebanner
Copy link
Contributor Author

ebanner commented Sep 20, 2024

Oh, thanks for asking. Your questions are making me realize I didn't fully think this through.

what purpose does the weekly have (outside of pushing to 2 other slacks) if this is daily

The weekly job posts all events happening this week. It's basically exactly how the current workflow it set up to post e.g. these messages.

The daily will just post events happening today.

Should this job ignore Monday so only the weekly job runs?

No it shouldn't. But it should take some care. I'm thinking on Monday the weekly should run first then the daily.

There's something about that solution that seems a bit ick. But since they're posting messages to the same channel, it's what I can think to do right now.

@ebanner ebanner force-pushed the add-daily-meetup-reminders branch from b065721 to 683b1d9 Compare September 23, 2024 19:01
@ebanner
Copy link
Contributor Author

ebanner commented Sep 23, 2024

@iBotPeaches I went ahead and modified the daily workflow to run 5 minutes past the hour to address this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post daily meetup event reminders
2 participants