Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with conditionally rendered fields in React #1097

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

@fulopkovacs fulopkovacs self-assigned this Jan 4, 2025
Copy link

nx-cloud bot commented Jan 4, 2025

View your CI Pipeline Execution ↗ for commit 7df5f77.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 4s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 30s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-04 22:53:49 UTC

Copy link

pkg-pr-new bot commented Jan 4, 2025

Open in Stackblitz

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1097

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1097

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1097

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1097

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1097

@tanstack/valibot-form-adapter

npm i https://pkg.pr.new/@tanstack/valibot-form-adapter@1097

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1097

@tanstack/yup-form-adapter

npm i https://pkg.pr.new/@tanstack/yup-form-adapter@1097

@tanstack/zod-form-adapter

npm i https://pkg.pr.new/@tanstack/zod-form-adapter@1097

commit: 7df5f77

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.61%. Comparing base (be7f9bf) to head (7df5f77).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
+ Coverage   86.60%   86.61%   +0.01%     
==========================================
  Files          29       29              
  Lines        1172     1173       +1     
  Branches      287      289       +2     
==========================================
+ Hits         1015     1016       +1     
  Misses        144      144              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fulopkovacs fulopkovacs force-pushed the fix-conditionally-rendered-fields branch from cbdabf5 to c0785db Compare January 4, 2025 21:27
@fulopkovacs fulopkovacs force-pushed the fix-conditionally-rendered-fields branch from 21e0f9e to 3db30ab Compare January 4, 2025 22:49
@fulopkovacs fulopkovacs marked this pull request as ready for review January 6, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant