Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/location list updates #3541

Merged
merged 32 commits into from
Dec 12, 2023
Merged

Conversation

esurface
Copy link
Contributor

@esurface esurface commented Feb 28, 2023

Location List Updates

Multiple Location List Configuration

  • UI to add more than one location list
  • UI to delete or edit a location list
  • User cannot delete the default location list
  • Form author can add a text attribute (location_src="") to a form (coded)
  • Use "default" location list for device assignment
  • User can set a default location list to be used for device configuration
  • Form author selects a location list from a drop-down list containing the server-defined list of locations
  • "Delete" button for default location list should clear the content

Searchable Location Lists

  • Make the bottom most location searchable

Location List Bug Fixes

  • IDs cannot be numbers when importing them (e.g. districts with ID 1)
  • Same name but different ID fails the import (e.g. schools with different codes but same name under the same zone)
  • Use of districts with different IDs but same labels across different regions fails
  • Store location label as part of the record so that if IDs are replaced the data remains correct and is not lost

Location Levels

  • Update UI to show list of levels in vertical tab bar
  • Move 'Add Level' functionality to a button in the vertical tab bar
  • Clean up the location level metadata editing UI

Import and Export Location List

  • Add functionality to import and export a Location List JSON file
  • Modify the Import UI to be more of a 'wizard' style workflow

esurface added 25 commits February 23, 2023 11:21
@esurface esurface changed the base branch from develop to main November 1, 2023 22:37
@esurface esurface changed the base branch from main to develop November 1, 2023 22:38
@esurface esurface requested a review from chrisekelley November 1, 2023 22:38
Copy link
Contributor Author

@esurface esurface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add container with margin

const categories = JSON.stringify(appConfigCategories);

let locationListMetadataJSON = <any> await this.groupsService.getLocationLists(this.groupId)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions github-actions bot merged commit 18176d8 into develop Dec 12, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant