Skip to content

Commit

Permalink
switched observer on hintText from render
Browse files Browse the repository at this point in the history
fixed double event firing for onCheckboxClicked
  • Loading branch information
chrisekelley committed Jul 29, 2020
1 parent 4b20420 commit 605c04f
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion input/tangy-checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class TangyCheckbox extends PolymerElement {
type: String,
value: '',
reflectToAttribute: true,
observer: 'render'
observer: 'onHintTextChanged'
},
hasWarning: {
type: Boolean,
Expand Down Expand Up @@ -177,6 +177,10 @@ export class TangyCheckbox extends PolymerElement {

}

onHintTextChanged() {
this.$['hint-text'].innerHTML = this.hintText
}

applyLabel(label) {
this.$.checkbox.children['checkbox-text'].innerHTML = this.label
}
Expand Down

0 comments on commit 605c04f

Please sign in to comment.