-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement playlists #60
base: master
Are you sure you want to change the base?
Conversation
UpdateThis is a small update since this pr is getting a bit big. The main features work: creating/deleting a playlist, adding/removing songs and playing songs from a playlist. On the code side here's some changes i made:
I have some doubts on the design/functionality so i would like to know your thoughts on these:
Sorry for the long comment :essaying: but i wanted to ask instead of doing things randomly >.< I will mark this pr as ready after this discussion and after the sidebar branch (#88) gets merged as that will cause a couple of conflicts. |
|
I wanted to suggest some UI changes to the PR, but the review was getting way too big, to avoid making our life's hard I created a PR with all the UI changes I was going to request, could you please take a look at it? You can merge it into your master if everything looks good and we can proceed with this one. Amazing job with the playlist! |
That's awesome! Thank you so much!! I'll take a look at it in the following days. |
@duduBTW I left some comments on your PR, please have a look when you have the time. |
@D0m1nos Fixed and replied to all the comments left there. |
@duduBTW Thanks! I left a small note, after that i think it's good to go. |
This pr implements playlists.
TODO:
Other features (probably in separate prs):