-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 온보딩 ui 변경 #127
Merged
Merged
[feat] 온보딩 ui 변경 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jokwanhee
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~~~~ 🔥
이슈!
- Network 클래스에서 리스너가 사용되는 것 같아요! 그런데 해당 리스너를 제때 해제해주지 않아서 메모리 누수 나는 것 같은데 한 번 확인 부탁드립니다! (전역으로 사용되니 어쩔 수 없나 싶기도합니다..)
- 요거는 궁금한 거에요!! -> inviteCode 를 StateFlow로 사용해서 Databinding 하던데, 여기서 한 번씩 빌드할 때, 에러납니다.. clean project하면 괜찮아지는데, flow-databinding의 호환성 문제일까요..?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📝 Work Desciption
📚 Reference 혹은 궁금한 사항들
화이팅~~