Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] 운동 뷰 QA 2차 수정 #146

Merged
merged 5 commits into from
Apr 29, 2024
Merged

[QA] 운동 뷰 QA 2차 수정 #146

merged 5 commits into from
Apr 29, 2024

Conversation

hyunjium
Copy link
Collaborator

📌 관련 이슈

📷 screenshot

📝 Work Desciption

  • 운동 뷰 히스토리 비어있을 때 흰 파일 위 마진 52dp, 아래 마진 59dp로 수정
  • 운동 뷰 오늘의 운동 ~ 오늘 미션 마진 홈 뷰에 맞게 변경
  • 마이페이지 내 정보 뷰 '이름'을 '별명'으로 수정

📚 Reference 혹은 궁금한 사항들

@hyunjium hyunjium added Pull Request 🔥 pr 날릴때 현지 🐱 엄니 QA qa 관련 작업 labels Apr 26, 2024
@hyunjium hyunjium added this to the 2차 스프린트 milestone Apr 26, 2024
@hyunjium hyunjium self-assigned this Apr 26, 2024
Jokwanhee
Jokwanhee reviewed Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@Jokwanhee Jokwanhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상대방 아이콘이 둘 다 검정머리 녀석으로 보임 !

해당 QA는 진행된건가요?

@hyunjium
Copy link
Collaborator Author

제가 테스트 할 때는 아이콘이 제대로 나와서, 혹시 제대로 안 나오면 말씀해주세요!

Jokwanhee
Jokwanhee approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@Jokwanhee Jokwanhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 👍

l2zh
l2zh approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@l2zh l2zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@hyunjium hyunjium merged commit 5278522 into develop Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l2zh l2zh l2zh approved these changes

@Jokwanhee Jokwanhee Jokwanhee approved these changes

Assignees

@hyunjium hyunjium

Labels
Pull Request 🔥 pr 날릴때 QA qa 관련 작업 현지 🐱 엄니
Projects
[Motiroid] 2차 스프린트
Status: 🤝 Done
Milestone
2차 스프린트
Development

Successfully merging this pull request may close these issues.

[QA] 운동 뷰 QA 2차 수정
3 participants
@hyunjium @Jokwanhee @l2zh