[QA] 기디 qa 반영 #82
Merged
[QA] 기디 qa 반영 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,6 +33,7 @@ class MainActivity : AppCompatActivity() { | |||
| setContentView(binding.root) | |||
| initView() | |||
| setupTokenRefreshListener() | |||
| Timber.tag("로그").e("생성") | |||
There was a problem hiding this comment.
제거해도 좋을 것 같아요 !
|
|
||
| override fun onDestroy() { | ||
| super.onDestroy() | ||
| Timber.tag("로그").e("삭제") |
| @@ -50,7 +67,11 @@ class LoginFragment : BindingFragment<FragmentLoginBinding>(R.layout.fragment_lo | |||
| when (uiState) { | |||
| is UiState.Success -> { | |||
| authViewModel.resetLoginState() | |||
| findNavController().navigate(R.id.action_loginFragment_to_termsOfUseFragment) | |||
| if (motivooStorage.isUserMatched) { | |||
There was a problem hiding this comment.
isUserMatched는 온보딩을 본 후 매칭이 끊겼을 때 문제가 생길 수 있을 것 같습니다. 적절한 값으로 바꿔주시면 더 정확할 것 같습니다 !!
giovannijunseokim
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📷 screenshot
Screen_recording_20240119_055634.mp4
📝 Work Desciption
📚 Reference 혹은 궁금한 사항들
다들 화이팅!