Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Stat Tracking #351

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Josephfallen
Copy link

I have added a basic stat tracking package to squad JS. I find that it would be useful if squad JS had this by default hence me making this PR

@werewolfboy13
Copy link
Collaborator

First concerns is the eslint disable flags. Why is that there?

squad-server/plugins/basic_stats.js Outdated Show resolved Hide resolved
@@ -245,6 +245,14 @@
"plugin": "TeamRandomizer",
"enabled": true,
"command": "randomize"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be in the template folders and generation commands ran,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squad-server/templates/config-template.json?

config.json Outdated Show resolved Hide resolved
squad-server/plugins/basic_stats.js Outdated Show resolved Hide resolved
squad-server/plugins/basic_stats.js Outdated Show resolved Hide resolved
squad-server/plugins/basic_stats.js Outdated Show resolved Hide resolved
squad-server/plugins/basic_stats.js Outdated Show resolved Hide resolved
squad-server/plugins/basic-stats.js Outdated Show resolved Hide resolved
squad-server/plugins/basic-stats.js Outdated Show resolved Hide resolved
Re added TKs and RPD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants