내가 작성한 글 확인하기 기능 구현 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soopeach
approved these changes
Nov 22, 2023
| posts.filter { postPreview -> | ||
| val date = Date(postPreview.date) | ||
| Log.d("TODOREMOVE", "${date.year}, ${date.month + 1}, ${date.date}") | ||
| date.month + 1 == month && year == date.year && day == date.date |
|
|
||
| override suspend fun getMyPostPreviews(uid: Long): Result<List<PostPreview>> { | ||
| val response = postService.myPosts(uid) | ||
| response.body()?.map { it.toPostPreview() } ?: throw Exception(response.message()) |
There was a problem hiding this comment.
넵 그리고 최근에 post 서버 내려갔었을 때 글 불러오니까 앱 터지더라구요 예외처리 안되어있는 부분 찾아서 해줘야 할 것 같습니다.
| data class PostPreview( | ||
| val poster: User, |
There was a problem hiding this comment.
네이밍에 많이 신경쓰지 못했네요..하핫 좀더 신경써서 고쳐보죠
| val id: Long, | ||
| val liked: Boolean = false, |
There was a problem hiding this comment.
요런 불린 타입 변수들 변수명이 is~~면 조금 더 명확해서 좋았던 것 같은데 나중에 전체적으로 바꿔봐요..!
| @@ -49,7 +49,7 @@ fun AppScreen(startWorker: () -> Unit) { | |||
| val splashViewModel = koinViewModel<SplashViewModel>() | |||
|
|
|||
| val splashState = splashViewModel.splashState.collectAsStateWithLifecycle() | |||
| AppScreenContent(startWorker, navController) | |||
| // AppScreenContent(startWorker, navController) | |||
There was a problem hiding this comment.
밑에
when (splashState.value) {
SplashState.InitialState -> SplashScreen()
SplashState.SignInState -> SignInScreen { splashViewModel.finishSignIn() }
SplashState.SignedInState -> AppScreenContent(startWorker, navController)
}코드에서 AppScreenContent 를 실행하는데 중복코드여서 주석했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 작업 내용
🧐 변경된 내용
🥳 동작 화면
🤯 이슈 번호
이슈 수정 후
🥲 비고