-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AlgaeIntake #26
Open
imnienting
wants to merge
29
commits into
main
Choose a base branch
from
ALGAE-IntakeSubsystem
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: AlgaeIntake #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
移除了有問題的vendor檔案
移除了錯誤的Vendor檔案
修改了壹些命名上的錯誤
增加功能 可以按按鈕到三層不同高度 也可以回到初始高度 可以切換成搖桿模式 手動調整高度 並加入limit switch
發現忘記加回到初始位置的 Command 把他加上去
嘗試照著 checkstyle 想要的方式改了一些順序
又改了一次
應該是最後一次了
他都不一次講完 又改一次順序
修改了命名上的問題
新增了運行的程式碼
把 Timer 的東西先刪除
移除了應當放在command的程式碼以及註釋留下一些之後可能要改的東西
把他放進了 periodic 就會一直重複執行 我不確定這樣改對不對
Elevator subsystem
把 rotateMotor 的東西刪除,加了一些東西在 constant 裏面
Revert "Elevator subsystem"
變成兩個 encoder ,加了 PID |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
把 Timer 的東西先刪除,我之後應該會改成用電流限制或在討論看看秒數要怎麼改