Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision2 #42

Merged
merged 23 commits into from
Feb 13, 2025
Merged

Vision2 #42

merged 23 commits into from
Feb 13, 2025

Conversation

Hannahjjj97
Copy link
Contributor

把只有limelight的程式丟進這個branch

Hannahjjj97 and others added 5 commits February 12, 2025 19:03
加入AutomaticCapture()
把limelight的程式丟進來
some modifications to pass styleCheck
把手殘按到的刪掉
some modifications to pass styleCheck
@capy0827 capy0827 requested a review from kennhung February 12, 2025 12:56
some modifications to pass styleCheck
Copy link
Member

@kennhung kennhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有給一些建議
build fail 需要先修一下

src/main/java/frc/robot/Constants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/vision/TagTracking.java Outdated Show resolved Hide resolved
capy0827 and others added 9 commits February 12, 2025 23:49
把getCT()加回去
some modifications to pass styleCheck
some modifications to pass styleCheck
some modifications to pass styleCheck
some modifications to pass styleCheck
刪了用不到的東西
remove unused import
相機名字更正,不用變數存 camMod
把出錯的刪掉
Copy link
Member

@kennhung kennhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有幾個可以更好的地方

  1. 不要有重複的程式碼
  2. 有很多不用定義成 class member 的東西
  3. 有些完全沒用可以被刪掉的東西

src/main/java/frc/robot/Constants.java Outdated Show resolved Hide resolved
capy0827 and others added 2 commits February 13, 2025 12:57
把一些東西刪掉
移除會造成衝突的空格
disable styleCheck
auto formatting
some modifications to pass styleCheck
把重複 command 簡化
@Hannahjjj97 Hannahjjj97 requested a review from kennhung February 13, 2025 10:37
把 return 補了上去
變成一個神奇的東西一直轉換
@Hannahjjj97 Hannahjjj97 requested review from kennhung and removed request for kennhung February 13, 2025 12:23
@Hannahjjj97 Hannahjjj97 added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 02883cf Feb 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants