-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vision2 #42
Merged
Merged
Vision2 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
加入AutomaticCapture()
把limelight的程式丟進來
some modifications to pass styleCheck
把手殘按到的刪掉
some modifications to pass styleCheck
some modifications to pass styleCheck
kennhung
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有給一些建議
build fail 需要先修一下
把getCT()加回去
some modifications to pass styleCheck
some modifications to pass styleCheck
some modifications to pass styleCheck
some modifications to pass styleCheck
刪了用不到的東西
remove unused import
相機名字更正,不用變數存 camMod
把出錯的刪掉
kennhung
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有幾個可以更好的地方
- 不要有重複的程式碼
- 有很多不用定義成 class member 的東西
- 有些完全沒用可以被刪掉的東西
kennhung
requested changes
Feb 13, 2025
把一些東西刪掉
移除會造成衝突的空格
disable styleCheck
auto formatting
some modifications to pass styleCheck
把重複 command 簡化
把 return 補了上去
變成一個神奇的東西一直轉換
kennhung
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
把只有limelight的程式丟進這個branch