[FIX] 추천장소리스트 API 옵셔널 처리 (#26) #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'develop' into fix/#26
cirtuare
approved these changes
Feb 15, 2025
Comment on lines
41
to
45
| var walkingTime: SpotType.WalkingDistanceType = .fifteen | ||
|
|
||
| var restaurantPrice: SpotType.RestaurantPriceType = .aboveFiftyThousand | ||
| var restaurantPrice: SpotType.RestaurantPriceType = .aboveFiftyThousand // TODO: 옵셔널로 변경 | ||
|
|
||
| var cafePrice: SpotType.CafePriceType = .aboveTenThousand | ||
| var cafePrice: SpotType.CafePriceType = .aboveTenThousand // TODO: 옵셔널로 변경 |
There was a problem hiding this comment.
🐿️
위에서 새롭게 선언한 default value 사용해주면 될 것 같아요 !
Comment on lines
15
to
17
| let defaultWalkingTime: SpotType.WalkingDistanceType = .fifteen | ||
| let defaultRestaurantPrice: SpotType.RestaurantPriceType = .aboveFiftyThousand | ||
| let defaultCafePrice: SpotType.CafePriceType = .aboveTenThousand |
There was a problem hiding this comment.
🐿️🐿️
이거 그냥 SpotType에 있는 각각의 enum에 static let default: Self = .fifteen로 선언해서 사용하는 건 어떨까요?(불러올 때 SpotType.CafePriceType.default) 이 방법이 아니더라도 default 값 구조체를 만든다던지 해서 구조화하면 좋을 것 같습니다.
Merge branch 'develop' into fix/#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
💥 To be sure
🌰 Resolve issue