Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading StreamInfo twice on first VideoDetailFragment opening #11959

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix loading StreamInfo twice on first VideoDetailFragment opening #11959

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffe26d8
Fix loading StreamInfo twice on first VideoDetailFragment opening
Stypox Jan 26, 2025
01bf855
Fix naming in VideoDetailFragment: video->stream, videoUrl->url
Stypox Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/src/main/java/org/schabi/newpipe/util/NavigationHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,12 @@ public static void openVideoDetailFragment(@NonNull final Context context,
if (fragment instanceof VideoDetailFragment && fragment.isVisible()) {
onVideoDetailFragmentReady.run((VideoDetailFragment) fragment);
} else {
// Specify no videoUrl here, otherwise the VideoDetailFragment will start loading the
// video automatically if it's the first time it is being opened, but then
// onVideoDetailFragmentReady will kick in and start another loading process.
// See VideoDetailFragment.wasCleared() and its usage in doInitialLoadLogic().
final VideoDetailFragment instance = VideoDetailFragment
.getInstance(serviceId, url, title, playQueue);
.getInstance(serviceId, null, title, playQueue);
instance.setAutoPlay(autoPlay);

defaultTransaction(fragmentManager)
Expand Down
Loading