feat/#18-DI 라이브러리 Koin에서 Dagger Hilt로 Migration #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJJoonngg
reviewed
Sep 25, 2023
|
|
||
| open class BaseViewModel : ViewModel(), KoinComponent { | ||
| @HiltViewModel | ||
| open class BaseViewModel @Inject constructor() : ViewModel() { |
There was a problem hiding this comment.
BaseVieModel에는 따로 HiltViewModel을 선언할 필요는 없을거 같습니다.
추후에 @Inject 를 사용하는 viewmodel 에서 재선언해서 사용하게 되니, 따로 어노테이션은 없어도 될거 같네요~
There was a problem hiding this comment.
아 그러면 각각 ViewModel에서 따로 사용하는 거군요 감사합니다~ 수정할께요!
JJJoonngg
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧨이슈
🔍 상세 내용 (해결 내용)
💡 참고자료 및 공유할만한 자료 (선택)
❕후속 진행 이슈