This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Feature rt transparency #383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er into the branch
…es the crashes related to the absence of an any hit shader
…ency & Fixed layered shadows
DBouma
suggested changes
Jun 17, 2019
VZout
suggested changes
Jun 18, 2019
| @@ -266,7 +267,13 @@ namespace wr::d3d12 | |||
| geometry_descs[i].Triangles.VertexCount = geom.m_num_vertices; | |||
| geometry_descs[i].Triangles.VertexBuffer.StartAddress = geom.vertex_buffer->m_buffer->GetGPUVirtualAddress() + (geom.m_vertices_offset * geom.m_vertex_stride); | |||
| geometry_descs[i].Triangles.VertexBuffer.StrideInBytes = geom.m_vertex_stride; | |||
| geometry_descs[i].Flags = D3D12_RAYTRACING_GEOMETRY_FLAG_OPAQUE; | |||
| geometry_descs[i].Flags = allow_transparency ? D3D12_RAYTRACING_GEOMETRY_FLAG_NONE : D3D12_RAYTRACING_GEOMETRY_FLAG_OPAQUE; | |||
There was a problem hiding this comment.
i don't like this especially at the end of the block. if we want to merge this you need to show me performance numbers on multiple types of scenes.
- Refactored Reflection, Shadows, AO tasks to use inheritance on the RT Hybrid data - Use of transparency is taken directly from the AS build data, except for path tracing, as that task has an override. - Gave some structure to the imgui layout - Changed Destroy function for the ShaderTable, now correctly set to nullptr, as that is also checked in dispatch rays - Acted on the feedback received from the PR.
…ency # Conflicts: # src/render_tasks/d3d12_rtao_task.hpp
VZout
approved these changes
Jun 20, 2019
|
accepted but see comments also don't merge before variable roughness |
…ency # Conflicts: # src/engine_registry.cpp # src/render_tasks/d3d12_rt_reflection_task.hpp # src/render_tasks/d3d12_rt_shadow_task.hpp # src/render_tasks/d3d12_rtao_task.hpp
…ask was preventing the shader tables to be created therefore crashing the renderer in release mode. Fixed that, as well as renaming padding
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added transparency to all pipelines except full raytracing