w2-ProjectGuessWho-SofieRydmark #200
Conversation
There was a problem hiding this comment.
Your Guess Who game looks very good. The sound when you guess a bad character is amazing. There is only one small detail that I realized does not work properly on the desktop. When you guess a person and move to a win-or-lose screen you can see a white area and a half of the "Find out" button. Was that a plan in the design? On the phone looks like everything is ok.
Great job!
| </optgroup> | ||
| <optgroup label="other"> | ||
| <option value="smoker">a smoking habit</option> | ||
| <option value="smoker">a smoker</option> |
There was a problem hiding this comment.
I think the name change is not compatible with a sentence: "Does the person have?". Maybe would be better with a smoking habit, or a cigaret?
| </optgroup> | ||
| </select> | ||
|
|
||
| <button id="filter" class="filled-button">FIND OUT</button> | ||
|
|
There was a problem hiding this comment.
Good idea with a counter, it look nice on the game
| @@ -34,7 +40,7 @@ const CHARACTERS = [ | |||
| img: 'images/jai.svg', | |||
| hair: 'black', | |||
| eyes: 'brown', | |||
| accessories: [], | |||
| accessories: 'none', | |||
There was a problem hiding this comment.
Does it work better if we change "[]" to 'none'?
| generateBoard(); | ||
| setSecretCharacter(); | ||
| selectQuestion(); | ||
| alert('lets play!') |
There was a problem hiding this comment.
Is that alert making display a place to put a name?
Link to project: https://project-guesswho-sofierydmark.netlify.app/