Guess who #209
Open
Guess who #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 30, 2022 15:40
Bibiruu
reviewed
Sep 11, 2022
There was a problem hiding this comment.
Overall code was really well put together. The pink level was almost fully reached. Saw you said about starting the counter so thats a good idea. I think comment lines help. This would get a grip of the code first glance/ helps beginners to understand how you built your code. Would be nice to see those perhaps. Good job regarding this project!
| @@ -171,7 +173,7 @@ const CHARACTERS = [ | |||
| img: 'images/josephine.svg', | |||
| hair: 'grey', | |||
| eyes: 'brown', | |||
| accessories: [], | |||
| accessories: ['earrings'], | |||
There was a problem hiding this comment.
I like the extra values given, gives more versatility to the stack
| @@ -231,3 +231,8 @@ button { | |||
| border: none; | |||
| } | |||
| } | |||
|
|
|||
| /****** SWEET ALERT ******/ | |||
| .swal-button { | |||
There was a problem hiding this comment.
The swal effect gives a nice effect to the game with a simple code. Good job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.