Fannys happy-thought-app #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling for the displayed messages
HIPPIEKICK
approved these changes
Oct 30, 2024
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Inconsolata:[email protected]&family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap" | ||
| rel="stylesheet"> | ||
| <title>Fannys Happy Thought App</title> |
src/App.jsx
Outdated
Comment on lines
10
to
12
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
One empty line is enough
src/App.jsx
Outdated
Comment on lines
5
to
7
| <> | ||
| <ThoughtPage /> | ||
| </> |
There was a problem hiding this comment.
No need for React fragment if you're only returning one element
| @@ -0,0 +1,166 @@ | |||
| .thought-list { | |||
| list-style-type: none; | |||
There was a problem hiding this comment.
Please set your VSC so one tab = 2 spaces. It gets easier to read
| import "./DisplayThought.css" | ||
|
|
||
| export const DisplayThoughts = ({ happyThoughts, isLoading, postLike }) => { | ||
| if (isLoading) { |
There was a problem hiding this comment.
Same here - hard to read with this super big indentation 😅
Comment on lines
3
to
4
| import { useState, useEffect } from 'react' | ||
| import { DisplayThoughts } from "./DisplayThought" |
There was a problem hiding this comment.
Consistency with single or double quotes please
| //postcall for likes on thoughts | ||
| const postLike = async (thoughtId) => { | ||
| try { | ||
| const response = await fetch(LIKE_URL.replace("THOUGHT_ID", thoughtId), { |
|
Thank you for your feedback, @HIPPIEKICK! 😊 I’m not sure why the indentation keeps reverting to 4 spaces when I’ve set the default to 2. 😅 I’ll look into it, but for now, I’ve updated the code based on your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://fh-happythoughtsapp.netlify.app