Labyrinth project by Emilia, Nina & Sandra week 12 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| } | ||
| return ( | ||
| <Outerwrapper coordinates={coordinates}> |
There was a problem hiding this comment.
Cool that you've used the coordinated to create this logic.
|
|
||
| return ( | ||
| <Direction> | ||
| <DirectionBtn1 className={isActive ? 'hidden-btn' : null} type="button" onClick={toggleDisplay}>Directions</DirectionBtn1> |
There was a problem hiding this comment.
Nice touch with the toggleDisplay. It adds something to the UX that you have to click to see the directions.
| reducers: { | ||
|
|
||
| setUsername: (state, action) => { | ||
| state.username = `${new Date().getTime()}+${action.payload}` |
There was a problem hiding this comment.
Makes a big difference that you added the time-stamp.
edv-rd
reviewed
May 7, 2023
| return ( | ||
| <Outerwrapper coordinates={coordinates}> | ||
| <Innerwrapper> | ||
| {coordinates === '' && <StartScreen />} |
There was a problem hiding this comment.
These two lines could probably be shortened to {coordinates === '' ? : }, or something like that, I think :)
|
|
||
| return ( | ||
| <Direction> | ||
| <DirectionBtn1 className={isActive ? 'hidden-btn' : null} type="button" onClick={toggleDisplay}>Directions</DirectionBtn1> |
There was a problem hiding this comment.
Kind of the reverse of my last comment :), I remember reading that you could use className={isActive && 'hidden-btn'} instead of using null!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://labyrinthw12-reactredux.netlify.app/