Adds support for source maps (Working) #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the process function to disable inline source maps, so PostCSS will provide them separately in the result object.
|
Nice. What Svelte versions is this compatible with? Will it work with any old [email protected]? |
|
This shouldn't change the supported Svelte version but Svelte wont be able to make use of the sourcemaps until #1863 is merged. |
TehShrike
reviewed
Dec 2, 2018
| .process(css) | ||
| .then(code => ({ code })) | ||
| .process(css, { | ||
| from: filename, |
There was a problem hiding this comment.
So PostCSS is cool with a from option property whose value is undefined?
There was a problem hiding this comment.
undefined? Svelte passes the filename into the callback which then gets passed to the process function and into postcss from. I tested it and it works fine on my system... am I missing something obvious?
Note: In the latest commit I fixed the name from fileName to filename, do you have that commit locally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for source maps. This should be merged asap in light of sveltejs/svelte#1863.
Comparison with #4.
SourceMapGeneratornot a string or bare object. Before passing the sourcemap to svelte we convert it to a bare objectfilenamenotfileName