feat(auto-complete): support empty api #4908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweijie0812
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
uyarn
reviewed
Jan 10, 2025
liweijie0812
commented
Jan 11, 2025
| @@ -131,7 +131,7 @@ export default defineComponent({ | |||
| /> | |||
| ); | |||
| // 联想词列表 | |||
| const listContent = ( | |||
| const listContent = Array.isArray(props.options) && ( | |||
There was a problem hiding this comment.
跟React 端处理逻辑一致
uyarn
reviewed
Jan 22, 2025
| @@ -143,18 +143,21 @@ export default defineComponent({ | |||
| highlightKeyword={props.highlightKeyword} | |||
| filterable={props.filterable} | |||
| filter={props.filter} | |||
| empty={renderTNodeJSX('empty')} | |||
There was a problem hiding this comment.
这里传入已经是renderTNodeJSX处理过的结果，和option-list的props的定义不符，而且内部又重新处理了一遍 这里应该改成props.empty即可 最好验证下两个情况的效果
There was a problem hiding this comment.
已在外层处理好，再传给option-list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
emptyAPI，用于配置空状态下的下拉内容展示☑️ 请求合并前的自查清单