feat: bcs-monitor支持X-Partial-Response #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifooth
reviewed
Jan 2, 2025
| @@ -76,12 +76,14 @@ func (t *TenantAuthMiddleware) NewHandler(handlerName string, handler http.Handl | |||
| } | |||
|
|
|||
| scopeClusteID := r.Header.Get("X-Scope-ClusterId") | |||
| partialResponse := r.Header.Get("X-Partial-Response") | |||
There was a problem hiding this comment.
这里的合法性校验是在thanos那处理了么？ 正常如果填写不合法，直接返回错误
There was a problem hiding this comment.
thanos处理了：
支持true的情况："1", "t", "T", "true", "TRUE", "True"
支持false的情况："0", "f", "F", "false", "FALSE", "False"
LidolLxf
force-pushed
the
feat_partial_header
branch
from
c323bef to
fd6a17c
Compare
ifooth
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: bcs-monitor支持X-Partial-Response